An initial implementation of the phase noise channel #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsalan-motamedi
added
the
no changelog
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #513 +/- ##
===========================================
+ Coverage 89.77% 89.84% +0.07%
===========================================
Files 92 93 +1
Lines 6072 6098 +26
===========================================
+ Hits 5451 5479 +28
+ Misses 621 619 -2
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ziofil
reviewed
Nov 1, 2024
ziofil
reviewed
Nov 2, 2024
ziofil
reviewed
Nov 2, 2024
apchytr
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Adds the phase noise with a Fock representation.
Description of the Change:
Added a class under
Channel. Please note that if we wanted to actually write a Fock array for this channel, it would be extremely heavy (I ran into memory issues). Therefore, we implement contractions withPhaseNoisein a particular way, using a custum rrshift method. I believe a similar logic was used in lab before.Benefits:
Enables us to apply phase noise.
Possible Drawbacks:
Could be slow.